Compile error on Ubuntu Linux - wrong number of arguments to luahelper_taskisrunning
Hi, I'm trying to build jamplus on Ubuntu Linux, and I'm getting a compile error in execunix.c, line 751:
execunix.c: In function 'my_wait':
execunix.c:751: error: too few arguments to function 'luahelper_taskisrunning'
It's right, it's meant to have two arguments and only one is provided, and adding ", status" to the line makes it compile, but this code has been in since August last year so I'm surprised it's not been noticed earlier - have I missed something?
Also, is this the right place to report things like compile errors? The 'New issue' tab looked a bit over the top, and I'm not sure how much you use github - the forum seems the most active of the three options.
RE: Compile error on Ubuntu Linux - wrong number of arguments to luahelper_taskisrunning - Added by Joshua Jensen almost 3 years ago
Re: luahelper_taskisrunning... Oops! :) Testing all 3 platforms before pushing takes a while, and some days, I am lazy... :)
You can report compile errors here or in the issue tracker. Compile errors generally need to be resolved quickly, so I'm happy with either method.
Features or bugs should really end up in the issue tracker, as I don't always have time to get to them immediately (Life Happens...). If they're posted in the forum, they are fresh on our minds to begin with, but we might lose track of them over time. In the issue tracker, they stick out like a sore thumb and are embarrassing to me. ;)
I've only ever received one merge request on GitHub. It worked out pretty well, and I would definitely recommend it as a way of submitting patches.
RE: Compile error on Ubuntu Linux - wrong number of arguments to luahelper_taskisrunning - Added by Ben Hymers almost 3 years ago
I was thinking that actually, there are a couple of pieces of software I use on github which I've had requests for (and that I've been able to sort out on my own in the meantime), perhaps forking them would be a good idea. Good suggestion :) And thanks for looking at this!